linux-kernel - Re: [PATCH v3 1/4] x86/split_lock: Move Split and Bus lock code to a dedicated file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee91fb42-7a06-4082-80af-9bd1401e06be@amd.com>
Date: Wed, 7 Aug 2024 11:12:03 +0530
From: Ravi Bangoria <ravi.bangoria@....com>
To: Tom Lendacky <thomas.lendacky@....com>, tglx@...utronix.de,
 mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
 seanjc@...gle.com, pbonzini@...hat.com, jmattson@...gle.com
Cc: hpa@...or.com, rmk+kernel@...linux.org.uk, peterz@...radead.org,
 james.morse@....com, lukas.bulwahn@...il.com, arjan@...ux.intel.com,
 j.granados@...sung.com, sibs@...natelecom.cn, nik.borisov@...e.com,
 michael.roth@....com, nikunj.dadhania@....com, babu.moger@....com,
 x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
 santosh.shukla@....com, ananth.narayan@....com, sandipan.das@....com,
 manali.shukla@....com, Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH v3 1/4] x86/split_lock: Move Split and Bus lock code to a
 dedicated file

>> diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
>> index 5857a0f5d514..9f74e0011f01 100644
>> --- a/arch/x86/kernel/cpu/Makefile
>> +++ b/arch/x86/kernel/cpu/Makefile
>> @@ -27,6 +27,7 @@ obj-y			+= aperfmperf.o
>>  obj-y			+= cpuid-deps.o
>>  obj-y			+= umwait.o
>>  obj-y 			+= capflags.o powerflags.o
>> +obj-y			+= bus_lock.o
> 
> Since the whole file is protected by a "#if defined", why not just use
> that here and conditionally build it?
> 
> You could also create a Kconfig that is set when CPU_SUP_INTEL is
> selected and, later when CPU_SUP_AMD is selected, and use that
> (CONFIG_X86_BUS_LOCK or such).

New CONFIG seems like a better option. Will respin with that.

Thanks for the review,
Ravi