linux-kernel - Re: [PATCH 1/1] selinux: Fix potential counting error in avc_add_xperms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb0d43b5-dc2a-6aec-da5b-493c86b3ae8b@huaweicloud.com>
Date: Wed, 7 Aug 2024 14:27:51 +0800
From: "Leizhen (ThunderTown)" <thunder.leizhen@...weicloud.com>
To: Paul Moore <paul@...l-moore.com>, Zhen Lei <thunder.leizhen@...wei.com>,
 Stephen Smalley <stephen.smalley.work@...il.com>
Cc: Ondrej Mosnacek <omosnace@...hat.com>, selinux@...r.kernel.org,
 linux-kernel@...r.kernel.org, Nick Kralevich <nnk@...gle.com>,
 Jeff Vander Stoep <jeffv@...gle.com>
Subject: Re: [PATCH 1/1] selinux: Fix potential counting error in
 avc_add_xperms_decision()



On 2024/8/7 5:55, Paul Moore wrote:
> On Tue, Aug 6, 2024 at 9:26 AM Stephen Smalley
> <stephen.smalley.work@...il.com> wrote:
>> On Tue, Aug 6, 2024 at 2:51 AM <thunder.leizhen@...weicloud.com> wrote:
>>> From: Zhen Lei <thunder.leizhen@...wei.com>
>>>
>>> The count increases only when a node is successfully added to
>>> the linked list.
>>>
>>> Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
>>> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
>>
>> This looks correct to me ...
> 
> It looks good to me too, unless I hear any objections I'm going to
> merge this into selinux/stable-6.11 and send it up to Linux during the
> v6.11-rcX cycle.
> 
>> ... but I also notice that the caller is not
>> checking or handling the return code for the -ENOMEM situation.
> 
> Good catch.  We should also fix this, ideally in the same PR where we
> send the count/len fix.
> 
> Zhen Lei, would you mind working on a separate fix for checking the
> error code in the caller?

Yeah, I'd love to.

> 

-- 
Regards,
  Zhen Lei