linux-kernel - Re: [PATCH v1 10/10] arm64: dts: exynos: Add initial support for Samsung Galaxy S8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <250fc005-3a76-4168-b7d7-b450c5b47e9e@kernel.org>
Date: Wed, 7 Aug 2024 11:22:05 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ivo.ivanov.ivanov1@...il.com, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh+dt@...nel.org>
Cc: linux-samsung-soc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 10/10] arm64: dts: exynos: Add initial support for
 Samsung Galaxy S8

On 07/08/2024 10:28, ivo.ivanov.ivanov1@...il.com wrote:
> From: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> 
> Samsung Galaxy S8 (SM-G950F), codenamed dreamlte, is a mobile phone
> from 2017. It features 4GB RAM, 64GB UFS 2.1, Exynos 8895 SoC and a
> 1440x2960 Super AMOLED display.
> 
> This initial device tree enables SimpleFB, PSTORE and GPIO keys.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> ---
>  arch/arm64/boot/dts/exynos/Makefile           |   1 +
>  .../boot/dts/exynos/exynos8895-dreamlte.dts   | 126 ++++++++++++++++++
>  2 files changed, 127 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
> 
> diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile
> index d7f2191c2..18f5a3eed 100644
> --- a/arch/arm64/boot/dts/exynos/Makefile
> +++ b/arch/arm64/boot/dts/exynos/Makefile
> @@ -7,5 +7,6 @@ dtb-$(CONFIG_ARCH_EXYNOS) += \
>  	exynos7-espresso.dtb		\
>  	exynos7885-jackpotlte.dtb	\
>  	exynos850-e850-96.dtb		\
> +	exynos8895-dreamlte.dtb		\
>  	exynosautov9-sadk.dtb		\
>  	exynosautov920-sadk.dtb
> diff --git a/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts b/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
> new file mode 100644
> index 000000000..5c8351b99
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
> @@ -0,0 +1,126 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Samsung Galaxy S8 (dreamlte/SM-G950F) device tree source
> + *
> + * Copyright (c) 2024, Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> + */
> +
> +/dts-v1/;
> +#include "exynos8895.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +/ {
> +	model = "Samsung Galaxy S8 (SM-G950F)";
> +	compatible = "samsung,dreamlte", "samsung,exynos8895";
> +	chassis-type = "handset";
> +
> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		framebuffer0: framebuffer@...00000 {
> +			status= "okay";

Drop, it was not disabled. Also, please follow DTS coding style
regarding order of properties.

> +			compatible = "simple-framebuffer";
Best regards,
Krzysztof