linux-kernel - Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7b4ea8a-74c5-40db-bf11-f8345f570ef5@web.de>
Date: Wed, 7 Aug 2024 13:06:39 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Lizhi Hou <lizhi.hou@....com>, dri-devel@...ts.freedesktop.org,
 Oded Gabbay <ogabbay@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, George Yang <George.Yang@....com>,
 king.tam@....com, Max Zhen <max.zhen@....com>, Min Ma <min.ma@....com>,
 Narendra Gutta <VenkataNarendraKumar.Gutta@....com>,
 Sonal Santan <sonal.santan@....com>
Subject: Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI
 Engine

If you temporarily find the circumstances too challenging for applications
of scope-based resource management, I suggest to use the following statements instead
(so that a bit of redundant code can be avoided).

…
> +++ b/drivers/accel/amdxdna/aie2_pci.c
> @@ -0,0 +1,182 @@
…
> +static int aie2_init(struct amdxdna_dev *xdna)
> +{
…
> +	release_firmware(fw);
> +	return 0;

	ret = 0;
	goto release_fw;

…
> +release_fw:
> +	release_firmware(fw);
> +
> +	return ret;
> +}
…

Otherwise (in case further collateral evolution will become more desirable):
…
> +static int aie2_init(struct amdxdna_dev *xdna)
> +{
…
> +	const struct firmware *fw;

I propose to take another software design option better into account.

* You may reduce the scope of such a local variable.

* How do you think about to use the attribute “__free(firmware)”?
  https://elixir.bootlin.com/linux/v6.11-rc2/source/include/linux/firmware.h#L214

…
> +	ret = request_firmware(&fw, ndev->priv->fw_path, &pdev->dev);
…

Regards,
Markus