linux-kernel - Re: [PATCH v3 9/9] arm64: dts: ti: Add support for J742S2 EVM board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807120629.3bo2cu3wlpkixwrp@flattered>
Date: Wed, 7 Aug 2024 07:06:29 -0500
From: Nishanth Menon <nm@...com>
To: Beleswar Prasad Padhi <b-padhi@...com>
CC: Manorit Chawdhry <m-chawdhry@...com>,
        Vignesh Raghavendra
	<vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>, Rob Herring
	<robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
	<conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Udit Kumar
	<u-kumar1@...com>,
        Neha Malcom Francis <n-francis@...com>,
        Aniket Limaye
	<a-limaye@...com>
Subject: Re: [PATCH v3 9/9] arm64: dts: ti: Add support for J742S2 EVM board

On 15:11-20240807, Beleswar Prasad Padhi wrote:
> For series,
> Reviewed-By: Beleswar Padhi <b-padhi@...com>
[...]
> > +/ {
> > +	model = "Texas Instruments J742S2 EVM";
> > +	compatible = "ti,j742s2-evm", "ti,j742s2";
> > +
> > +	memory@...00000 {
> > +		device_type = "memory";
> > +		bootph-all;
> > +		/* 16G RAM */
> > +		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
> > +		      <0x00000008 0x80000000 0x00000003 0x80000000>;

Sigh.. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117

1. "compatible" <- not present
2. "reg" <- present
3. "ranges" <- not present
4. Standard/common properties (defined by common bindings, e.g. without
   vendor-prefixes) <- bootph-all and device_type
5. Vendor-specific properties -> not present
6. "status" (if applicable) -> not present
7. Child nodes, where each node is preceded with a blank line -> not
present

So:

	/* 16G RAM */
	reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
	      <0x00000008 0x80000000 0x00000003 0x80000000>;
	device_type = "memory";
	bootph-all;

??

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D