linux-kernel - Re: [PATCH v3 6/9] arm64: dts: ti: Split k3-j784s4-j742s2-evm-common.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240807130648.elyf66euunm6iowy@illusion>
Date: Wed, 7 Aug 2024 08:06:48 -0500
From: Nishanth Menon <nm@...com>
To: Manorit Chawdhry <m-chawdhry@...com>
CC: Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Udit Kumar
	<u-kumar1@...com>,
        Neha Malcom Francis <n-francis@...com>,
        Aniket Limaye
	<a-limaye@...com>
Subject: Re: [PATCH v3 6/9] arm64: dts: ti: Split
 k3-j784s4-j742s2-evm-common.dtsi

On 22:40-20240731, Manorit Chawdhry wrote:
> k3-j784s4-j742s2-evm-common.dtsi will be included in k3-j742s2-evm.dts
> at a later point so move j784s4 related stuff to k3-j784s4-evm.dts

How about this:

Refactor J784s2-evm to a common file which uses the
superset device to allow reuse in j742s2-evm which uses the subset part.

Use a similar style commit message in other refactoring patches as well.

> 
> Signed-off-by: Manorit Chawdhry <m-chawdhry@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-j784s4-evm.dts           | 49 ++++++++++++++++++++++
>  .../boot/dts/ti/k3-j784s4-j742s2-evm-common.dtsi   | 42 -------------------
>  2 files changed, 49 insertions(+), 42 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> index e3730b2bca92..2543983b7fe7 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
> @@ -5,4 +5,53 @@
>   * EVM Board Schematics: https://www.ti.com/lit/zip/sprr458
>   */
>  
> +/dts-v1/;
> +
> +#include <dt-bindings/net/ti-dp83867.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include "k3-j784s4.dtsi"
>  #include "k3-j784s4-j742s2-evm-common.dtsi"
> +
> +/ {
> +	compatible = "ti,j784s4-evm", "ti,j784s4";
> +	model = "Texas Instruments J784S4 EVM";
> +
> +	memory@...00000 {
> +		device_type = "memory";
> +		bootph-all;
> +		/* 32G RAM */
> +		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
> +		      <0x00000008 0x80000000 0x00000007 0x80000000>;
I understand you are moving the nodes in and it is just copy paste, but
we have an opportunity to clean the nodes up a bit here.

Same as https://lore.kernel.org/all/20240807120629.3bo2cu3wlpkixwrp@flattered/

> +	};
> +
> +	reserved_memory: reserved-memory {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +
> +		c71_3_dma_memory_region: c71-dma-memory@...00000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0xab000000 0x00 0x100000>;
> +			no-map;
> +		};
> +
> +		c71_3_memory_region: c71-memory@...00000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0xab100000 0x00 0xf00000>;
> +			no-map;
> +		};
> +	};
> +};
> +
> +&mailbox0_cluster5 {
> +	mbox_c71_3: mbox-c71-3 {
> +		ti,mbox-rx = <2 0 0>;
> +		ti,mbox-tx = <3 0 0>;
> +	};
> +};
> +
> +&c71_3 {
> +	status = "okay";

Status comes last. I know that these coding standards are new, and it
takes a little getting used to and one wishes there was a linting tool
of some sort to make this easier.. but for now, eyes are the only way
out :(.


> +	mboxes = <&mailbox0_cluster5 &mbox_c71_3>;
> +	memory-region = <&c71_3_dma_memory_region>,
> +			<&c71_3_memory_region>;
> +};

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D