linux-kernel - Re: [PATCH] i2c: mt65xx: Avoid double initialization of restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <rmn65agbosovoto3zwr6pqio32ad4uyhekxncvqx46w7eyj4wj@cxhtrvmlj5sv>
Date: Wed, 7 Aug 2024 01:15:14 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: qii.wang@...iatek.com, matthias.bgg@...il.com, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH] i2c: mt65xx: Avoid double initialization of restart_flag
 in isr

Hi Angelo,

On Tue, Aug 06, 2024 at 11:45:37AM GMT, AngeloGioacchino Del Regno wrote:
> In the mtk_i2c_irq() handler, variable restart_flag is initialized
> to zero and then reassigned with I2C_RS_TRANSFER if and only if
> auto_restart is enabled.
> 
> Avoid a double initialization of this variable by transferring the
> auto_restart check to the restart_flag declaration.
> 
> This commit brings no functional changes.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

merged to i2c/i2c-host.

Thanks,
Andi