linux-kernel - Re: [PATCH RESEND] Documentation: devres: fix error about PCI devres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240809183751.GA205131@bhelgaas>
Date: Fri, 9 Aug 2024 13:37:51 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Philipp Stanner <pstanner@...hat.com>
Cc: Jonathan Corbet <corbet@....net>, Mark Brown <broonie@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH RESEND] Documentation: devres: fix error about PCI devres

On Fri, Aug 09, 2024 at 11:52:48AM +0200, Philipp Stanner wrote:
> The documentation states that pcim_enable_device() will make "all PCI
> ops" managed. This is totally false, only a small subset of PCI
> functions become managed that way. Implicating otherwise has caused at
> least one bug so far, namely in commit 8558de401b5f ("drm/vboxvideo: use
> managed pci functions").
> 
> Change the function summary so the functions dangerous behavior becomes
> obvious.
> 
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

s/Implicating/Suggesting/
s/functions dangerous/function's dangerous/

> ---
> +CC PCI and Bjorn.
> 
> Bjorn, btw. neither PCI nor you are printed by getmaintainers for the
> touched document. Possibly one might want to think about fixing that
> somehow.
> But I don't think it's a huge deal.
> ---
>  Documentation/driver-api/driver-model/devres.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> index ac9ee7441887..5f2ee8d717b1 100644
> --- a/Documentation/driver-api/driver-model/devres.rst
> +++ b/Documentation/driver-api/driver-model/devres.rst
> @@ -391,7 +391,7 @@ PCI
>    devm_pci_remap_cfgspace()	: ioremap PCI configuration space
>    devm_pci_remap_cfg_resource()	: ioremap PCI configuration space resource
>  
> -  pcim_enable_device()		: after success, all PCI ops become managed
> +  pcim_enable_device()		: after success, some PCI ops become managed
>    pcim_iomap()			: do iomap() on a single BAR
>    pcim_iomap_regions()		: do request_region() and iomap() on multiple BARs
>    pcim_iomap_regions_request_all() : do request_region() on all and iomap() on multiple BARs
> -- 
> 2.45.2
>