linux-kernel - Re: [PATCH RESEND] Documentation: devres: fix error about PCI devres

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87plq8hzch.fsf@trenco.lwn.net>
Date: Fri, 16 Aug 2024 16:33:50 -0600
From: Jonathan Corbet <corbet@....net>
To: Philipp Stanner <pstanner@...hat.com>, Mark Brown <broonie@...nel.org>,
 David Lechner <dlechner@...libre.com>, Uwe Kleine-König
 <u.kleine-koenig@...gutronix.de>, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>, Philipp Stanner <pstanner@...hat.com>, Andy
 Shevchenko <andriy.shevchenko@...ux.intel.com>, Bjorn Helgaas
 <bhelgaas@...gle.com>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org
Subject: Re: [PATCH RESEND] Documentation: devres: fix error about PCI devres

Philipp Stanner <pstanner@...hat.com> writes:

> The documentation states that pcim_enable_device() will make "all PCI
> ops" managed. This is totally false, only a small subset of PCI
> functions become managed that way. Implicating otherwise has caused at
> least one bug so far, namely in commit 8558de401b5f ("drm/vboxvideo: use
> managed pci functions").
>
> Change the function summary so the functions dangerous behavior becomes
> obvious.
>
> Signed-off-by: Philipp Stanner <pstanner@...hat.com>
> ---
> +CC PCI and Bjorn.
>
> Bjorn, btw. neither PCI nor you are printed by getmaintainers for the
> touched document. Possibly one might want to think about fixing that
> somehow.
> But I don't think it's a huge deal.
> ---
>  Documentation/driver-api/driver-model/devres.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

jon