linux-kernel - Re: [PATCH 1/1] perf debuginfo: Fix the build with !HAVE_DWARF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7ciushSwEfj7yW4rtDEJBTcCB991V4cswwFEL+cv6QF2pg@mail.gmail.com>
Date: Fri, 9 Aug 2024 12:39:47 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Adrian Hunter <adrian.hunter@...el.com>, Ian Rogers <irogers@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, Kan Liang <kan.liang@...ux.intel.com>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] perf debuginfo: Fix the build with !HAVE_DWARF_SUPPORT

On Fri, Aug 9, 2024 at 7:47 AM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> In that case we have a set of placeholder functions, one of them uses a
> 'Dwarf_Addr' type that is not present as it is defined in the missing
> DWARF libraries, so provide a placeholder typedef for that as well.
>
> The build error before this patch, a static build out of 'make -C tools/perf build-test':
>
>   In file included from util/annotate.c:28:
>   util/debuginfo.h:44:46: error: unknown type name ‘Dwarf_Addr’
>      44 |                                              Dwarf_Addr *offs __maybe_unused,
>         |                                              ^~~~~~~~~~
>   make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:106: util/annotate.o] Error 1
>   make[6]: *** Waiting for unfinished jobs....
>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Acked-by: Namhyung Kim <namhyung@...nel.org>

> ---
>
> I have this in perf-tools-next.

Thanks,
Namhyung

>
> ---
>  tools/perf/util/debuginfo.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/debuginfo.h b/tools/perf/util/debuginfo.h
> index 4d65b8c605fc5445..ad6422c3f8ca3ef6 100644
> --- a/tools/perf/util/debuginfo.h
> +++ b/tools/perf/util/debuginfo.h
> @@ -40,6 +40,8 @@ static inline void debuginfo__delete(struct debuginfo *dbg __maybe_unused)
>  {
>  }
>
> +typedef void Dwarf_Addr;
> +
>  static inline int debuginfo__get_text_offset(struct debuginfo *dbg __maybe_unused,
>                                              Dwarf_Addr *offs __maybe_unused,
>                                              bool adjust_offset __maybe_unused)
> --
> 2.45.2
>