linux-kernel - Re: [PATCH v3] rust: Kbuild: Skip -fmin-function-alignment in bindgen flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72=mo1ujT11Rai+9J1G3a4OUTzQAx307=WF+h0t2=m7qeg@mail.gmail.com>
Date: Sat, 10 Aug 2024 00:10:02 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Zehui Xu <zehuixu@....edu.cn>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com, 
	boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, 
	benno.lossin@...ton.me, a.hindborg@...sung.com, aliceryhl@...gle.com, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] rust: Kbuild: Skip -fmin-function-alignment in bindgen flags

On Wed, Jul 31, 2024 at 3:45 PM Zehui Xu <zehuixu@....edu.cn> wrote:
>
> GCC 14 recently added -fmin-function-alignment option and the
> root Makefile uses it to replace -falign-functions when available.
> However, this flag can cause issues when passed to the Rust
> Makefile and affect the bindgen process. Bindgen relies on
> libclang to parse C code, and currently does not support the
> -fmin-function-alignment flag, leading to compilation failures
> when GCC 14 is used.
>
> This patch addresses the issue by adding -fmin-function-alignment
> to the bindgen_skip_c_flags in rust/Makefile. This prevents the
> flag from causing compilation issues.
>
> Link: https://lore.kernel.org/linux-kbuild/20240222133500.16991-1-petr.pavlu@suse.com/
> Signed-off-by: Zehui Xu <zehuixu@....edu.cn>

Applied to `rust-fixes` -- thanks everyone!

    [ Matthew and Gary confirm function alignment should not change
      the ABI in a way that bindgen would care about, thus we did
      not need the extra logic for bindgen from v2. - Miguel ]

    [ Reworded title. - Miguel ]

Cheers,
Miguel