linux-kernel - Re: [PATCH v3] rust: Kbuild: Skip -fmin-function-alignment in bindgen flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240813180117.3c259c17@eugeo>
Date: Tue, 13 Aug 2024 18:01:17 +0100
From: Gary Guo <gary@...yguo.net>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Zehui Xu <zehuixu@....edu.cn>, ojeda@...nel.org, alex.gaynor@...il.com,
 wedsonaf@...il.com, boqun.feng@...il.com, bjorn3_gh@...tonmail.com,
 benno.lossin@...ton.me, a.hindborg@...sung.com, aliceryhl@...gle.com,
 rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] rust: Kbuild: Skip -fmin-function-alignment in
 bindgen flags

On Thu, 8 Aug 2024 17:07:51 +0200
Miguel Ojeda <miguel.ojeda.sandonis@...il.com> wrote:

> On Wed, Aug 7, 2024 at 12:57 PM Gary Guo <gary@...yguo.net> wrote:
> >
> > This patch itself looks fine to me, so
> >
> > Reviewed-by: Gary Guo <gary@...yguo.net>
> >
> > We use -fmin-function-alignment for GCC and use -falign-functions for
> > clang. These options affect codegen only so it's fine to ignore them
> > for bindgen.  
> 
> Thanks Gary.
> 
> > Although it appears to me that we currently don't set function
> > alignments for Rust codegen. Maybe that's worth considering adding?  
> 
> Yeah, agreed. I think currently there is no way for that in `rustc`
> (apart from `fn_align`) -- I have created an issue about it and a few
> others and linked them all at
> https://github.com/Rust-for-Linux/linux/issues/355.


I think `-Cllvm-args=-align-all-functions=foo` should work?

Best,
Gary