[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <349e240b-64cf-43f6-9ebe-2598bff9f6d9@tuxon.dev>
Date: Fri, 9 Aug 2024 10:24:12 +0300
From: claudiu beznea <claudiu.beznea@...on.dev>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
chris.brandt@...esas.com, andi.shyti@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, geert+renesas@...der.be,
magnus.damm@...il.com, p.zabel@...gutronix.de,
linux-renesas-soc@...r.kernel.org, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v3 08/11] i2c: riic: Add support for fast mode plus
On 08.08.2024 18:25, Wolfram Sang wrote:
>
>> + if (info->fast_mode_plus && t->bus_freq_hz == I2C_MAX_FAST_MODE_PLUS_FREQ)
>> + riic_clear_set_bit(riic, 0, ICFER_FMPE, RIIC_ICFER);
>
> Shouldn't that be something like
>
> t->bus_freq_hz > I2C_MAX_FAST_MODE_FREQ
You're right, it should be.
Looking though the HW manual, it specifies this about FPM bit: "Set this
bit to 1 when using the transmission rate within a range up to 1 Mbps".
Thank you,
Claudiu Beznea
>
> ? On R-Car, we have to enable the FM+ bit as soon as we exceed plain
> FastMode bus speeds.
>
Powered by blists - more mailing lists