[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <93d79fbd-8d1c-4a80-bf65-d4e597247573@gmail.com>
Date: Fri, 9 Aug 2024 17:40:44 +0300
From: "Ceclan, Dumitru" <mitrutzceclan@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
devnull+dumitru.ceclan.analog.com@...nel.org
Cc: Michael.Hennerich@...log.com, conor+dt@...nel.org,
devicetree@...r.kernel.org, dumitru.ceclan@...log.com, jic23@...nel.org,
krzk+dt@...nel.org, lars@...afoo.de, linux-iio@...r.kernel.org,
linux-kernel@...r.kernel.org, robh@...nel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad7173: add support for ad4113
On 09/08/2024 17:30, Christophe JAILLET wrote:
> Le 09/08/2024 à 12:33, Dumitru Ceclan via B4 Relay a écrit :
>> From: Dumitru Ceclan <dumitru.ceclan-OyLXuOCK7orQT0dZR+AlfA@...lic.gmane.org>
>>
>> This commit adds support for the AD4113 ADC.
>> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
>> converter (ADC) that integrates an analog front end (AFE) for four
>> fully differential or eight single-ended inputs.
>>
>> Signed-off-by: Dumitru Ceclan <dumitru.ceclan-OyLXuOCK7orQT0dZR+AlfA@...lic.gmane.org>
>> ---
>> drivers/iio/adc/ad7173.c | 36 +++++++++++++++++++++++++++++++++++-
>> 1 file changed, 35 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
>> index a854f2d30174..3ac09d326472 100644
>> --- a/drivers/iio/adc/ad7173.c
>> +++ b/drivers/iio/adc/ad7173.c
>> @@ -3,7 +3,7 @@
>> * AD717x and AD411x family SPI ADC driver
>> *
>> * Supported devices:
>> - * AD4111/AD4112/AD4114/AD4115/AD4116
>> + * AD4111/AD4112/AD4113/AD4114/AD4115/AD4116
>> * AD7172-2/AD7172-4/AD7173-8/AD7175-2
>> * AD7175-8/AD7176-2/AD7177-2
>> *
>> @@ -84,6 +84,7 @@
>> #define AD4111_ID AD7173_ID
>> #define AD4112_ID AD7173_ID
>> #define AD4114_ID AD7173_ID
>> +#define AD4113_ID 0x31D0
>
> Nitpick: others are in lowercase --> 0x31d0
>
>> #define AD4116_ID 0x34d0
>> #define AD4115_ID 0x38d0
>> #define AD7175_8_ID 0x3cd0
>
> Other than that, is there any reason to have this "random" order for these defines?
>
> CJ
>
It's not random, it was requested to order these defines by the ID value:
https://lore.kernel.org/all/CAHp75VcjcgnLkQWim1AVnyeRGFwwKpaWSCvrmqdv41Lx87hMKw@mail.gmail.com/
Powered by blists - more mailing lists