linux-kernel - Re: [PATCH v2 1/2] dt-bindings: adc: ad7173: add support for ad4113

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240809-autograph-sugar-e79e54fd7a24@spud>
Date: Fri, 9 Aug 2024 16:09:07 +0100
From: Conor Dooley <conor@...nel.org>
To: "Ceclan, Dumitru" <mitrutzceclan@...il.com>
Cc: dumitru.ceclan@...log.com, Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: adc: ad7173: add support for ad4113

On Fri, Aug 09, 2024 at 05:32:08PM +0300, Ceclan, Dumitru wrote:
> On 09/08/2024 17:21, Conor Dooley wrote:
> > On Fri, Aug 09, 2024 at 01:33:24PM +0300, Dumitru Ceclan via B4 Relay wrote:
> >> From: Dumitru Ceclan <dumitru.ceclan@...log.com>
> >>
> >> This commit adds bindings support for AD4113.
> >>
> >> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> >> converter (ADC) that integrates an analog front end (AFE) for four
> >> fully differential or eight single-ended inputs.
> >>
> >> Added ad4113 to the compatible list and the "avdd2-supply: false"
> >> restriction.
> >>
> >> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@...log.com>
> >> ---
> >>  Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> >> index 17c5d39cc2c1..ad15cf9bc2ff 100644
> >> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> >> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> >> @@ -28,6 +28,7 @@ description: |
> >>    Datasheets for supported chips:
> >>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf
> >>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf
> >> +    <AD4113: not released yet>
> > 
> > Am I meant to ack it with this placeholder? When will the document be
> > released?
> > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> > 
> Not really sure tbh, up to you. The document will be released in the upcoming months.
> 
> If it's considered best to wait until the docs are public and send another
> version with the correct link. 
> If not, and maintainers consider that these changes can be accepted even
> without viewing the datasheet, I'll send a patch when it goes public.

I don't really care, it's just to Jonathan I think. I'm happy enough
with you adding it when it is released.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)