linux-kernel - Re: [PATCH v2 2/2] iio: adc: ad7173: add support for ad4113

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a048baa-d9a7-4285-9242-7a32a594f226@wanadoo.fr>
Date: Fri, 9 Aug 2024 17:34:05 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: mitrutzceclan@...il.com
Cc: Michael.Hennerich@...log.com, christophe.jaillet@...adoo.fr,
 conor+dt@...nel.org, devicetree@...r.kernel.org,
 devnull+dumitru.ceclan.analog.com@...nel.org, dumitru.ceclan@...log.com,
 jic23@...nel.org, krzk+dt@...nel.org, lars@...afoo.de,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, robh@...nel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad7173: add support for ad4113

Le 09/08/2024 à 16:40, Ceclan, Dumitru a écrit :
> On 09/08/2024 17:30, Christophe JAILLET wrote:
>> Le 09/08/2024 à 12:33, Dumitru Ceclan via B4 Relay a écrit :
>>> From: Dumitru Ceclan <dumitru.ceclan-OyLXuOCK7orQT0dZR+AlfA-XMD5yJDbdMReXY1tMh2IBg@...lic.gmane.org>
>>>
>>> This commit adds support for the AD4113 ADC.
>>> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
>>> converter (ADC) that integrates an analog front end (AFE) for four
>>> fully differential or eight single-ended inputs.
>>>
>>> Signed-off-by: Dumitru Ceclan <dumitru.ceclan-OyLXuOCK7orQT0dZR+AlfA-XMD5yJDbdMReXY1tMh2IBg@...lic.gmane.org>
>>> ---
>>>    drivers/iio/adc/ad7173.c | 36 +++++++++++++++++++++++++++++++++++-
>>>    1 file changed, 35 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
>>> index a854f2d30174..3ac09d326472 100644
>>> --- a/drivers/iio/adc/ad7173.c
>>> +++ b/drivers/iio/adc/ad7173.c
>>> @@ -3,7 +3,7 @@
>>>     * AD717x and AD411x family SPI ADC driver
>>>     *
>>>     * Supported devices:
>>> - *  AD4111/AD4112/AD4114/AD4115/AD4116
>>> + *  AD4111/AD4112/AD4113/AD4114/AD4115/AD4116
>>>     *  AD7172-2/AD7172-4/AD7173-8/AD7175-2
>>>     *  AD7175-8/AD7176-2/AD7177-2
>>>     *
>>> @@ -84,6 +84,7 @@
>>>    #define AD4111_ID            AD7173_ID
>>>    #define AD4112_ID            AD7173_ID
>>>    #define AD4114_ID            AD7173_ID
>>> +#define AD4113_ID            0x31D0
>>
>> Nitpick: others are in lowercase --> 0x31d0
>>
>>>    #define AD4116_ID            0x34d0
>>>    #define AD4115_ID            0x38d0
>>>    #define AD7175_8_ID            0x3cd0
>>
>> Other than that, is there any reason to have this "random" order for these defines?
>>
>> CJ
>>
> 
> It's not random, it was requested to order these defines by the ID value:
> https://lore.kernel.org/all/CAHp75VcjcgnLkQWim1AVnyeRGFwwKpaWSCvrmqdv41Lx87hMKw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/
> 

Ok,

I thought about it, but it is not sorted either. (a few lines above the 
place you added the new #define):

#define AD7175_ID			0x0cd0
#define AD7176_ID			0x0c90

Maybe, it should be part of another patch to keep the logic by ID value?

CJ