linux-kernel - Re: [PATCH v3 3/3] nbd: correct the maximum value for discard sectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <584a1774-0268-4b3c-9a78-0f00073b9d74@kernel.dk>
Date: Fri, 9 Aug 2024 09:34:55 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Wouter Verhelst <w@...r.be>, Josef Bacik <josef@...icpanda.com>
Cc: Damien Le Moal <dlemoal@...nel.org>, linux-block@...r.kernel.org,
 nbd@...er.debian.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] nbd: correct the maximum value for discard sectors

On 8/8/24 1:06 AM, Wouter Verhelst wrote:
> The version of the NBD protocol implemented by the kernel driver
> currently has a 32 bit field for length values. As the NBD protocol uses
> bytes as a unit of length, length values larger than 2^32 bytes cannot
> be expressed.
> 
> Update the max_hw_discard_sectors field to match that.
> 
> Signed-off-by: Wouter Verhelst <w@...r.be>
> Fixes: 268283244c0f018dec8bf4a9c69ce50684561f46

This isn't the correct way to have a fixes line.

In general, please don't nest next versions under the previous posting,
and it's strongly recommended to have a cover letter that includes that
changed from version N to N+1. Otherwise we have to guess... So please
include that when posting v4.

-- 
Jens Axboe