[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZroMFpaP69uUfC14@pc220518.home.grep.be>
Date: Mon, 12 Aug 2024 15:20:22 +0200
From: Wouter Verhelst <w@...r.be>
To: Jens Axboe <axboe@...nel.dk>
Cc: Josef Bacik <josef@...icpanda.com>, Damien Le Moal <dlemoal@...nel.org>,
linux-block@...r.kernel.org, nbd@...er.debian.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] nbd: correct the maximum value for discard sectors
On Fri, Aug 09, 2024 at 09:34:55AM -0600, Jens Axboe wrote:
> On 8/8/24 1:06 AM, Wouter Verhelst wrote:
> > Fixes: 268283244c0f018dec8bf4a9c69ce50684561f46
>
> This isn't the correct way to have a fixes line.
Apologies Jens; beginner's mistake.
> In general, please don't nest next versions under the previous posting,
> and it's strongly recommended to have a cover letter that includes that
> changed from version N to N+1. Otherwise we have to guess... So please
> include that when posting v4.
Right, sorry. "git help send-email" gave an example of how to do
something like this for a "v2" patch series, which made me assume
(incorrectly) that this is what would be wanted. I should have checked
first, I guess.
Will send v4 (hopefully the last one) shortly with those fixes.
--
w@...r.{be,co.za}
wouter@...ep.be,fosdem.org,debian.org}
I will have a Tin-Actinium-Potassium mixture, thanks.
Powered by blists - more mailing lists