linux-kernel - Re: [PATCH] arm: Fix build issue with LD_DEAD_CODE_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b9aa586e-5685-4b5b-9732-81f2dec7120a@app.fastmail.com>
Date: Fri, 09 Aug 2024 16:47:41 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Yuntao Liu" <liuyuntao12@...wei.com>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: "Russell King" <linux@...linux.org.uk>,
 "Harith George" <mail2hgg@...il.com>, "Andrew Davis" <afd@...com>,
 "Russell King" <rmk+kernel@...linux.org.uk>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Andrew Morton" <akpm@...ux-foundation.org>,
 "Eric DeVolder" <eric.devolder@...cle.com>,
 "Masahiro Yamada" <masahiroy@...nel.org>
Subject: Re: [PATCH] arm: Fix build issue with LD_DEAD_CODE_DATA_ELIMINATION

On Thu, Aug 8, 2024, at 14:35, Yuntao Liu wrote:
> There is a build issue with LD segmentation fault, while
> CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is not enabled, as bellow.
>
> scripts/link-vmlinux.sh: line 49:  3796 Segmentation fault
>  (core dumped) ${ld} ${ldflags} -o ${output} ${wl}--whole-archive
>  ${objs} ${wl}--no-whole-archive ${wl}--start-group
>  ${libs} ${wl}--end-group ${kallsymso} ${btf_vmlinux_bin_o} ${ldlibs}
>
> The error occurs in older versions of the GNU ld with version earlier
> than 2.36. It makes most sense to have a minimum LD version as
> a dependency for HAVE_LD_DEAD_CODE_DATA_ELIMINATION and eliminate
> the impact of ".reloc  .text, R_ARM_NONE, ." when
> CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is not enabled.
>
> Fixes: ed0f94102251 ("ARM: 9404/1: arm32: enable 
> HAVE_LD_DEAD_CODE_DATA_ELIMINATION")
> Reported-by: Harith George <mail2hgg@...il.com>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Yuntao Liu <liuyuntao12@...wei.com>
> Link: 
> https://lore.kernel.org/all/14e9aefb-88d1-4eee-8288-ef15d4a9b059@gmail.com/

Looks good to me,

Acked-by: Arnd Bergmann <arnd@...db.de>