linux-kernel - Re: [PATCH v4 1/3] dt-bindings: reset: Add rk3576 reset definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D3BIJXIKYD7N.238B8AE16Y5AI@cknow.org>
Date: Fri, 09 Aug 2024 18:15:26 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Detlev Casanova" <detlev.casanova@...labora.com>,
 <linux-kernel@...r.kernel.org>
Cc: "Michael Turquette" <mturquette@...libre.com>, "Stephen Boyd"
 <sboyd@...nel.org>, "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski"
 <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Heiko
 Stuebner" <heiko@...ech.de>, "Philipp Zabel" <p.zabel@...gutronix.de>,
 "Elaine Zhang" <zhangqing@...k-chips.com>, <linux-clk@...r.kernel.org>,
 <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-rockchip@...ts.infradead.org>, <kernel@...labora.com>, "Sugar Zhang"
 <sugar.zhang@...k-chips.com>
Subject: Re: [PATCH v4 1/3] dt-bindings: reset: Add rk3576 reset definitions

On Fri Aug 9, 2024 at 2:54 PM CEST, Detlev Casanova wrote:
> Add reset ID defines for rk3576.
>
> Compared to the downstream bindings this uses continous gapless
> reset IDs starting at 1 instead of register offsets as IDs, as
> introduced in the RK3588 bindings.
> ...
> ---
>  .../dt-bindings/reset/rockchip,rk3576-cru.h   | 564 ++++++++++++++++++
>  1 file changed, 564 insertions(+)
>  create mode 100644 include/dt-bindings/reset/rockchip,rk3576-cru.h
>
> diff --git a/include/dt-bindings/reset/rockchip,rk3576-cru.h b/include/dt-bindings/reset/rockchip,rk3576-cru.h
> new file mode 100644
> index 0000000000000..8c968af4888d5
> --- /dev/null
> +++ b/include/dt-bindings/reset/rockchip,rk3576-cru.h
> @@ -0,0 +1,564 @@
> +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */
> + ...
> +
> +#ifndef _DT_BINDINGS_RESET_ROCKCHIP_RK3576_H
> +#define _DT_BINDINGS_RESET_ROCKCHIP_RK3576_H
> +
> +#define SRST_A_TOP_BIU			0
> +#define SRST_P_TOP_BIU			1

As requested you renumbered starting from '0', but the commit message
mentions "starting at 1". Same for patch 2 of this series.