linux-kernel - Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert ad7879 to yaml format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7d83c56-d59b-4c9b-87a1-31556b3ef5de@kernel.org>
Date: Sat, 10 Aug 2024 13:59:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..."
 <linux-input@...r.kernel.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert ad7879 to
 yaml format

On 09/08/2024 22:05, Frank Li wrote:
> +
> +maintainers:
> +  - Frank Li <Frank.Li@....com>
> +
> +properties:
> +  compatible:
> +    description: |
> +      for SPI slave, use "adi,ad7879"
> +      for I2C slave, use "adi,ad7879-1"
> +    enum:
> +      - adi,ad7879
> +      - adi,ad7879-1

Driver (and binding) could be fixed to use only one compatible, but
that's another task.

> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  touchscreen-max-pressure:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: maximum reported pressure
> +
> +  adi,resistance-plate-x:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: total resistance of X-plate (for pressure calculation)
> +
> +  touchscreen-swapped-x-y:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description: X and Y axis are swapped (boolean)
> +
> +  adi,first-conversion-delay:
> +    $ref: /schemas/types.yaml#/definitions/uint8
> +    minimum: 0
> +    maximum: 15
> +    description: |
> +      0-12: In 128us steps (starting with 128us)
> +      13  : 2.560ms
> +      14  : 3.584ms
> +      15  : 4.096ms
> +      This property has to be a '/bits/ 8' value
> +
> +  adi,acquisition-time:
> +    $ref: /schemas/types.yaml#/definitions/uint8
> +    enum: [0, 1, 2, 3]
> +    description: |
> +      0: 2us
> +      1: 4us
> +      2: 8us
> +      3: 16us
> +      This property has to be a '/bits/ 8' value
> +
> +  adi,median-filter-size:
> +    $ref: /schemas/types.yaml#/definitions/uint8
> +    enum: [0, 1, 2, 3]
> +    description: |
> +      0: disabled
> +      1: 4 measurements
> +      2: 8 measurements
> +      3: 16 measurements
> +      This property has to be a '/bits/ 8' value
> +
> +  adi,averaging:
> +    $ref: /schemas/types.yaml#/definitions/uint8
> +    enum: [0, 1, 2, 3]
> +    description: |
> +      0: 2 middle values (1 if median disabled)
> +      1: 4 middle values
> +      2: 8 middle values
> +      3: 16 values
> +      This property has to be a '/bits/ 8' value
> +
> +  adi,conversion-interval:
> +    $ref: /schemas/types.yaml#/definitions/uint8
> +    description: |
> +      0    : convert one time only
> +      1-255: 515us + val * 35us (up to 9.440ms)
> +      This property has to be a '/bits/ 8' value

All above should have the "default: 0", based on driver behavior.



Best regards,
Krzysztof