linux-kernel - Re: [PATCH] docs: fault-injection: document cache-filter feature for failslab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umyixKAYAdpBKd+O0Knb_cGGzFcQ8yJQWFNtnKCWxpiEKyw@mail.gmail.com>
Date: Mon, 12 Aug 2024 00:38:13 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Jonathan Corbet <corbet@....net>, kuba@...nel.org, 
	"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] docs: fault-injection: document cache-filter feature for failslab

2024年8月8日(木) 16:41 Breno Leitao <leitao@...ian.org>:
>
> On Wed, Aug 07, 2024 at 12:54:31PM -0600, Jonathan Corbet wrote:
> > Breno Leitao <leitao@...ian.org> writes:
> >
> > > The failslab fault injection mechanism has an undocumented capability
> > > that provides significant utility in testing and debugging. This feature,
> > > introduced in commit 4c13dd3b48fcb ("failslab: add ability to filter slab
> > > caches"), allows for targeted error injection into specific slab caches.
> > >
> > > However, it was inadvertently left undocumented at the time of its
> > > implementation.
> > >
> > > Add documentation for the cache-filter feature in the failslab mode
> > > description. Also, providing a practical example demonstrating how to
> > > use cache-filter to inject failures specifically when allocating socket
> > > buffers (skbs).
> > >
> > > Signed-off-by: Breno Leitao <leitao@...ian.org>
> > > ---
> > >  .../fault-injection/fault-injection.rst       | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> >
> > I've applied this, thanks.
> >
> > It seems to me that the fault-injection docs should really move under
> > dev-tools; does anybody object to that?
>
> I don't object at all. This doc should be inside dev-tools.

I also agree with moving the document.