[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <be2a8462-38fb-4e74-905d-12bc9f678082@acm.org>
Date: Mon, 12 Aug 2024 14:24:21 -0700
From: Bart Van Assche <bvanassche@....org>
To: Yihang Li <liyihang9@...wei.com>, James.Bottomley@...senPartnership.com,
martin.petersen@...cle.com
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
linuxarm@...wei.com, prime.zeng@...wei.com
Subject: Re: [PATCH v2] scsi: sd: retry command SYNC CACHE if format in
progress
On 8/9/24 6:59 PM, Yihang Li wrote:
> If formatting a suspended disk (such as formatting with different DIF
> type), the disk will be resuming first, and then the format command will
> submit to the disk through SG_IO ioctl.
>
> When the disk is processing the format command, the system does not submit
> other commands to the disk. Therefore, the system attempts to suspend the
> disk again and sends the SYNC CACHE command. However, the SYNC CACHE
> command will fail because the disk is in the formatting process, which
> will cause the runtime_status of the disk to error and it is difficult
> for user to recover it. Error info like:
>
> [ 669.925325] sd 6:0:6:0: [sdg] Synchronizing SCSI cache
> [ 670.202371] sd 6:0:6:0: [sdg] Synchronize Cache(10) failed: Result: hostbyte=0x00 driverbyte=DRIVER_OK
> [ 670.216300] sd 6:0:6:0: [sdg] Sense Key : 0x2 [current]
> [ 670.221860] sd 6:0:6:0: [sdg] ASC=0x4 ASCQ=0x4
>
> To solve the issue, retry the command until format command is finished.
>
> Signed-off-by: Yihang Li <liyihang9@...wei.com>
Reviewed-by: Bart Van Assche <bvanassche@....org>
If you want this patch to land in older kernels a "Cc: stable" tag will
have to be added.
Bart.
Powered by blists - more mailing lists