linux-kernel - Re: [PATCH 1/1] arm64: dts: imx8-ss-vpu: Fix imx8qm VPU IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4944000.31r3eYUQgx@steina-w>
Date: Mon, 12 Aug 2024 11:11:51 +0200
From: Alexander Stein <alexander.stein@...tq-group.com>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Peng Fan <peng.fan@....com>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: imx8-ss-vpu: Fix imx8qm VPU IRQs

Am Montag, 12. August 2024, 10:45:54 CEST schrieb Peng Fan:
> > Subject: [PATCH 1/1] arm64: dts: imx8-ss-vpu: Fix imx8qm VPU IRQs
> > 
> > imx8-ss-vpu only contained imx8qxp IRQ numbers, only mu2_m0 uses
> > the correct imx8qm IRQ number, as imx8qxp lacks this MU.
> > Fix this by providing imx8qm IRQ numbers in the main imx8-ss-vpu.dtsi
> > and override the IRQ numbers in SoC-specific imx8qxp-ss-vpu.dtsi,
> > similar to reg property for VPU core devices.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> > ---
> > I did not include a Fixes tag as adding support for imx8qxp and imx8qm
> > is split into several commits. It's at lease the combination of the
> > following commits:
> > 
> > 0d9968d98467d ("arm64: dts: freescale: imx8q: add imx vpu codec
> > entries") b4efce453f0ca ("arm64: dts: imx8qm: add vpu decoder and
> > encoder")
> 
> If you are using one patch to try to fix upper two commits, I think
> it would be better to separate the patch to fix the error of
> each upper commit and include Fixes tag.

Commit 0d9968d98467d ("arm64: dts: freescale: imx8q: add imx vpu codec
entries") is talking about imx8q. This is most probably i.MX8 family, while
I confused imx8q with imx8qxp, which is i.MX8X family...
The naming scheme is so confusing :(

For that reason I'll just add a Fixes for 0d9968d98467d.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/