linux-kernel - Re: [PATCH 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f823600-68c4-418f-b2bf-6d5d64a1ee56@kernel.org>
Date: Mon, 12 Aug 2024 11:12:19 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hui-Ping Chen <hpchen0nvt@...il.com>, miquel.raynal@...tlin.com,
 richard@....at, vigneshr@...com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, sumit.semwal@...aro.org, christian.koenig@....com,
 esben@...nix.com
Cc: linux-arm-kernel@...ts.infradead.org, linux-mtd@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new
 bindings

On 12/08/2024 11:02, Hui-Ping Chen wrote:
> 
> 
>>> +
>>> +      nand-ecc-step-size:
>>> +        enum: [512, 1024]
>> No defaults? So is this required?
> 
> This is required, but I will also add a default.

If this is required and should be in required: list. Default does not
make sense then... it contradicts the point of being required.

> 
> 
> 
>>> +
>>> +      nand-ecc-strength:
>>> +        enum: [8, 12, 24]
>> No defaults? So is this required?
> 
> This is required, but I will also add a default.

Ditto


Best regards,
Krzysztof