linux-kernel - Re: [PATCH 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33ae3c93-81cb-491c-a5b3-239c7c413eb3@kernel.org>
Date: Mon, 12 Aug 2024 11:13:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Hui-Ping Chen <hpchen0nvt@...il.com>, miquel.raynal@...tlin.com,
 richard@....at, vigneshr@...com, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, sumit.semwal@...aro.org, christian.koenig@....com,
 esben@...nix.com
Cc: linux-arm-kernel@...ts.infradead.org, linux-mtd@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH 2/2] mtd: rawnand: nuvoton: add new driver for the Nuvoton
 MA35 SoC

On 12/08/2024 11:10, Hui-Ping Chen wrote:
>>> +
>>> +/* NAND-type Flash BCH Error Data Registers */
>>> +#define MA35_NFI_REG_NANDECCED0	(0x960)
>>> +#define MA35_NFI_REG_NANDECCED1	(0x964)
>>> +#define MA35_NFI_REG_NANDECCED2	(0x968)
>>> +#define MA35_NFI_REG_NANDECCED3	(0x96C)
>>> +#define MA35_NFI_REG_NANDECCED4	(0x970)
>>> +#define MA35_NFI_REG_NANDECCED5	(0x974)
>>> +
>>> +/* NAND-type Flash Redundant Area Registers */
>>> +#define MA35_NFI_REG_NANDRA0		(0xA00)
>>> +#define MA35_NFI_REG_NANDRA1		(0xA04)
>>> +
>>> +#define SKIP_SPARE_BYTES	4
>>> +
>>> +/* BCH algorithm related constants and variables */
>>> +enum {
>>> +	eBCH_NONE = 0,
>>> +	eBCH_T8,
>>> +	eBCH_T12,
>>> +	eBCH_T24,
>>> +	eBCH_CNT
>>> +} E_BCHALGORITHM;
>>> +
>>> +static const int g_i32BCHAlgoIdx[eBCH_CNT] = {BCH_T8, BCH_T8, BCH_T12, BCH_T24};
>>> +static struct nand_ecclayout_user ma35_nand_oob;
>> Why this is file-scope?
> 
> I will remove the `static`.

No, why this cannot be instance dependent? Quick looks says it could.
And should.


Best regards,
Krzysztof