lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2024081244-emit-starlit-dd23@gregkh>
Date: Mon, 12 Aug 2024 16:40:13 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Abhinav Jain <jain.abhinav177@...il.com>
Cc: leah.rumancik@...il.com, djwong@...nel.org, linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	syzbot+55fb1b7d909494fd520d@...kaller.appspotmail.com
Subject: Re: [PATCH 6.1.y] xfs: remove WARN when dquot cache insertion fails

On Fri, Aug 09, 2024 at 07:26:40AM +0530, Abhinav Jain wrote:
> commit 4b827b3f305d ("xfs: remove WARN when dquot cache insertion fails")
> 
> Disk quota cache insertion failure doesn't require this warning as
> the system can still manage and track disk quotas without caching the
> dquot object into memory. The failure doesn't imply any data loss or
> corruption.
> 
> Therefore, the WARN_ON in xfs_qm_dqget_cache_insert function is aggressive
> and causes bot noise. I have confirmed there are no conflicts and also
> tested the using the C repro from syzkaller:
> https://syzkaller.appspot.com/text?tag=ReproC&x=15406772280000
> 
> Please do let me know if I missed out on anything as it's my first
> backport patch.

You lost all of the ownership and original signed-off-by attributes for
the commit :(

Please work with the xfs developers if they wish to see this backported
or not, that's up to them.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ