linux-kernel - [PATCH 6.1.y] xfs: remove WARN when dquot cache insertion fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240809015640.590433-1-jain.abhinav177@gmail.com>
Date: Fri,  9 Aug 2024 07:26:40 +0530
From: Abhinav Jain <jain.abhinav177@...il.com>
To: leah.rumancik@...il.com,
	djwong@...nel.org,
	linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Cc: Abhinav Jain <jain.abhinav177@...il.com>,
	syzbot+55fb1b7d909494fd520d@...kaller.appspotmail.com
Subject: [PATCH 6.1.y] xfs: remove WARN when dquot cache insertion fails

commit 4b827b3f305d ("xfs: remove WARN when dquot cache insertion fails")

Disk quota cache insertion failure doesn't require this warning as
the system can still manage and track disk quotas without caching the
dquot object into memory. The failure doesn't imply any data loss or
corruption.

Therefore, the WARN_ON in xfs_qm_dqget_cache_insert function is aggressive
and causes bot noise. I have confirmed there are no conflicts and also
tested the using the C repro from syzkaller:
https://syzkaller.appspot.com/text?tag=ReproC&x=15406772280000

Please do let me know if I missed out on anything as it's my first
backport patch.

Reported-by: syzbot+55fb1b7d909494fd520d@...kaller.appspotmail.com
Signed-off-by: Abhinav Jain <jain.abhinav177@...il.com>
---
 fs/xfs/xfs_dquot.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_dquot.c b/fs/xfs/xfs_dquot.c
index 8fb90da89787..7f071757f278 100644
--- a/fs/xfs/xfs_dquot.c
+++ b/fs/xfs/xfs_dquot.c
@@ -798,7 +798,6 @@ xfs_qm_dqget_cache_insert(
 	error = radix_tree_insert(tree, id, dqp);
 	if (unlikely(error)) {
 		/* Duplicate found!  Caller must try again. */
-		WARN_ON(error != -EEXIST);
 		mutex_unlock(&qi->qi_tree_lock);
 		trace_xfs_dqget_dup(dqp);
 		return error;
-- 
2.34.1