linux-kernel - Re: [PATCH v4 06/22] mm/zsmalloc: convert create_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <839f2c4b-5312-447c-a3de-6c8fc098876e@gmail.com>
Date: Fri, 9 Aug 2024 09:57:01 +0800
From: Alex Shi <seakeel@...il.com>
To: Vishal Moola <vishal.moola@...il.com>
Cc: alexs@...nel.org, Vitaly Wool <vitaly.wool@...sulko.com>,
 Miaohe Lin <linmiaohe@...wei.com>, Andrew Morton
 <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, minchan@...nel.org, willy@...radead.org,
 senozhatsky@...omium.org, david@...hat.com, 42.hyeyoo@...il.com,
 Yosry Ahmed <yosryahmed@...gle.com>, nphamcs@...il.com
Subject: Re: [PATCH v4 06/22] mm/zsmalloc: convert create_page_chain() and its
 users to use zpdesc



On 8/9/24 2:25 AM, Vishal Moola wrote:
>>> I'm not a fan of the names above. IMO, naming should follow some
>>> semblance of consistency regarding their purpose (or have comments
>>> that describe their purpose instead).
>>>
>>> At a glance zpdesc_set_zspage() and zpdesc_set_first() sound like they
>>> are doing similar things, but I don't think they serve similar purposes?
>> zpdesc_set_zspage() only used in one place, a helper maynot needed. Let me remove it.
>> Same thing for the alloc_zpdesc() and free_zpdesc(), they could be merge into using place.
> alloc_zpdesc() and free_zpdesc() are fine as is. The helper functions
> will be useful whenever memdescs can be allocated on their own, so its
> better to introduce it now.

Thanks for suggestion. will recover them in next version, maybe tomorrow if no more comments.