linux-kernel - Re: [PATCH] arm: Fix build issue with LD_DEAD_CODE_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zrok+yGp5epfcZTE@shell.armlinux.org.uk>
Date: Mon, 12 Aug 2024 16:06:35 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Harith George <mail2hgg@...il.com>
Cc: Yuntao Liu <liuyuntao12@...wei.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arnd@...db.de, afd@...com, linus.walleij@...aro.org,
	akpm@...ux-foundation.org, eric.devolder@...cle.com,
	masahiroy@...nel.org
Subject: Re: [PATCH] arm: Fix build issue with LD_DEAD_CODE_DATA_ELIMINATION

On Mon, Aug 12, 2024 at 01:21:59PM +0530, Harith George wrote:
> On 08-08-2024 18:05, Yuntao Liu wrote:
> > There is a build issue with LD segmentation fault, while
> > CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is not enabled, as bellow.
> > 
> > scripts/link-vmlinux.sh: line 49:  3796 Segmentation fault
> >   (core dumped) ${ld} ${ldflags} -o ${output} ${wl}--whole-archive
> >   ${objs} ${wl}--no-whole-archive ${wl}--start-group
> >   ${libs} ${wl}--end-group ${kallsymso} ${btf_vmlinux_bin_o} ${ldlibs}
> > 
> > The error occurs in older versions of the GNU ld with version earlier
> > than 2.36. It makes most sense to have a minimum LD version as
> > a dependency for HAVE_LD_DEAD_CODE_DATA_ELIMINATION and eliminate
> > the impact of ".reloc  .text, R_ARM_NONE, ." when
> > CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is not enabled.
> > 
> > Fixes: ed0f94102251 ("ARM: 9404/1: arm32: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION")
> > Reported-by: Harith George <mail2hgg@...il.com>
> > Suggested-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Yuntao Liu <liuyuntao12@...wei.com>
> > Link: https://lore.kernel.org/all/14e9aefb-88d1-4eee-8288-ef15d4a9b059@gmail.com/
> 
> Build tested. Solves the earlier build issue I was seeing.
> fwiw, you can add my tested by tag if needed.
> 
> Tested-by: Harith George <mail2hgg@...il.com>

(a) please see the note in my signature below.
(b) this tested-by needs to be collected by the submitter before it gets
    into the patch system.
(c) it needs to get into the patch system.

Bear in mind that as a result of (a), it's going to be better to get it
into the patch system sooner rather than later - I am expecting there to
be a period of time (weeks) where it will be impossible for me to read
the screen...

-- 
*** please note that I probably will only be occasionally responsive
*** for an unknown period of time due to recent eye surgery making
*** reading quite difficult.

RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!