[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <67255497-7bc9-4392-ab32-d0a6af75f5b0@kernel.org>
Date: Tue, 13 Aug 2024 16:37:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Shen Jianping (ME-SE/EAD2)" <Jianping.Shen@...bosch.com>,
"jic23@...nel.org" <jic23@...nel.org>, "lars@...afoo.de" <lars@...afoo.de>,
"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"dima.fedrau@...il.com" <dima.fedrau@...il.com>,
"marcelo.schmitt1@...il.com" <marcelo.schmitt1@...il.com>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"Lorenz Christian (ME-SE/EAD2)" <Christian.Lorenz3@...bosch.com>,
"Frauendorf Ulrike (ME/PJ-SW3)" <Ulrike.Frauendorf@...bosch.com>,
"Dolde Kai (ME-SE/PAE-A3)" <Kai.Dolde@...bosch.com>
Subject: Re: [PATCH v2 2/2] iio: imu: smi240: imu driver
On 13/08/2024 15:54, Shen Jianping (ME-SE/EAD2) wrote:
>>>> +
>>>> +MODULE_AUTHOR("Markus Lochmann <markus.lochmann@...bosch.com>");
>>>> +MODULE_AUTHOR("Stefan Gutmann <stefan.gutmann@...bosch.com>");
>>>> +MODULE_DESCRIPTION("Bosch SMI240 driver"); MODULE_LICENSE("Dual
>>>> +BSD/GPL");
>>>
>>> Hm? How many modules do you have here? What are their names?
>>>
>>> We have one module, named "Bosch SMI240 driver". Any problem here?
>>
>> Yes, you put MODULE_* to how many files? Two? Three? Why is it needed
>> everywhere?
>
> We put MODULE_* in all the *.c , just like the other IMU drivers already in source tree. They do the same.
That's not true. First, look at adis_buffer.c. no MODULE_XXX. Second,
maybe they have multiple modules, so the macros are expected. That's why
I asked you and you said you do not have more than one module.
Best regards,
Krzysztof
Powered by blists - more mailing lists