linux-kernel - RE: [PATCH v2 2/2] iio: imu: smi240: imu driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AM8PR10MB4721373BE7846741A2EC66DACD862@AM8PR10MB4721.EURPRD10.PROD.OUTLOOK.COM>
Date: Tue, 13 Aug 2024 14:51:07 +0000
From: "Shen Jianping (ME-SE/EAD2)" <Jianping.Shen@...bosch.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "jic23@...nel.org"
	<jic23@...nel.org>, "lars@...afoo.de" <lars@...afoo.de>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "dima.fedrau@...il.com"
	<dima.fedrau@...il.com>, "marcelo.schmitt1@...il.com"
	<marcelo.schmitt1@...il.com>, "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Lorenz Christian (ME-SE/EAD2)"
	<Christian.Lorenz3@...bosch.com>, "Frauendorf Ulrike (ME/PJ-SW3)"
	<Ulrike.Frauendorf@...bosch.com>, "Dolde Kai (ME-SE/PAE-A3)"
	<Kai.Dolde@...bosch.com>
Subject: RE: [PATCH v2 2/2] iio: imu: smi240: imu driver

Hi


...
>>>>> +
>>>>> +MODULE_AUTHOR("Markus Lochmann
><markus.lochmann@...bosch.com>");
>>>>> +MODULE_AUTHOR("Stefan Gutmann <stefan.gutmann@...bosch.com>");
>>>>> +MODULE_DESCRIPTION("Bosch SMI240 driver"); MODULE_LICENSE("Dual
>>>>> +BSD/GPL");
>>>>
>>>> Hm? How many modules do you have here? What are their names?
>>>>
>>>> We have one module, named  "Bosch SMI240 driver". Any problem here?
>>>
>>> Yes, you put MODULE_* to how many files? Two? Three? Why is it needed
>>> everywhere?
>>
>> We put MODULE_* in all the *.c , just like the other IMU drivers already in source
>tree. They do the same.
>
>That's not true. First, look at adis_buffer.c. no MODULE_XXX. Second, maybe they
>have multiple modules, so the macros are expected. That's why I asked you and
>you said you do not have more than one module.
>
 
Now I get the point , what you mean for "module".  Yes we have two modules. 
One module named "Bosch SMI240 driver" therefore we put MODULE_* in smi240_core.c 
And we have the second module named " Bosch SMI240 SPI driver " and we put therefore MODULE_* in smi240_spi.c