linux-kernel - Re: [PATCH v10 3/3] dt-bindings: input: pure gpio support for adp5588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240813-talon-uproar-f27c6f194d59@spud>
Date: Tue, 13 Aug 2024 16:27:55 +0100
From: Conor Dooley <conor@...nel.org>
To: "Agarwal, Utsav" <Utsav.Agarwal@...log.com>
Cc: "Rob Herring (Arm)" <robh@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Hennerich, Michael" <Michael.Hennerich@...log.com>,
	"Gaskell, Oliver" <Oliver.Gaskell@...log.com>,
	Conor Dooley <conor+dt@...nel.org>, "Sa, Nuno" <Nuno.Sa@...log.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Bimpikas, Vasileios" <Vasileios.Bimpikas@...log.com>,
	Conor Dooley <conor.dooley@...rochip.com>,
	"Artamonovs, Arturs" <Arturs.Artamonovs@...log.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [PATCH v10 3/3] dt-bindings: input: pure gpio support for adp5588

On Tue, Aug 13, 2024 at 11:50:41AM +0000, Agarwal, Utsav wrote:
> 
> 
> > -----Original Message-----
> > From: Rob Herring (Arm) <robh@...nel.org>
> > Sent: Tuesday, August 13, 2024 12:12 PM
> > To: Agarwal, Utsav <Utsav.Agarwal@...log.com>
> > Cc: devicetree@...r.kernel.org; Hennerich, Michael
> > <Michael.Hennerich@...log.com>; Gaskell, Oliver
> > <Oliver.Gaskell@...log.com>; Conor Dooley <conor+dt@...nel.org>; Sa, Nuno
> > <Nuno.Sa@...log.com>; linux-kernel@...r.kernel.org; Bimpikas, Vasileios
> > <Vasileios.Bimpikas@...log.com>; Conor Dooley
> > <conor.dooley@...rochip.com>; Artamonovs, Arturs
> > <Arturs.Artamonovs@...log.com>; Krzysztof Kozlowski <krzk+dt@...nel.org>;
> > linux-input@...r.kernel.org; Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Subject: Re: [PATCH v10 3/3] dt-bindings: input: pure gpio support for adp5588
> > 
> > [External]
> > 
> > 
> > On Tue, 13 Aug 2024 10:51:33 +0100, Utsav Agarwal wrote:
> > > Adding software support for enabling the pure gpio capability of the
> > > device - which allows all I/O to be used as GPIO. Previously, I/O
> > > configuration was limited by software to partial GPIO support only.
> > >
> > > When working in a pure gpio mode, the device does not require the
> > > certain properties and hence, the following are now made optional:
> > > 	- interrupts
> > > 	- keypad,num-rows
> > > 	- keypad,num-columns
> > > 	- linux,keymap
> > >
> > > However, note that the above are required to be specified when
> > > configuring the device as a keypad, for which dependencies have been added
> > > such that specifying either one requires the remaining as well.
> > >
> > > Also, note that interrupts are made optional, but required when the device
> > > has either been configured in keypad mode or as an interrupt controller.
> > > This has been done since they may not necessarily be used when leveraging
> > > the device purely for GPIO.
> > >
> > > Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> > > Signed-off-by: Utsav Agarwal <utsav.agarwal@...log.com>
> > > ---
> > >  .../devicetree/bindings/input/adi,adp5588.yaml     | 40 ++++++++++++++++++-
> > ---
> > >  1 file changed, 34 insertions(+), 6 deletions(-)
> > >
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/input/adi,adp5588.yaml:140:1: [error]
> > syntax error: could not find expected ':' (syntax)
> > 
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-
> > ci/linux/Documentation/devicetree/bindings/input/adi,adp5588.yaml: ignoring,
> > error parsing file
> > ./Documentation/devicetree/bindings/input/adi,adp5588.yaml:140:1: could not
> > find expected ':'
> > make[2]: *** Deleting file
> > 'Documentation/devicetree/bindings/input/adi,adp5588.example.dts'
> > Documentation/devicetree/bindings/input/adi,adp5588.yaml:140:1: could not
> > find expected ':'
> > make[2]: *** [Documentation/devicetree/bindings/Makefile:26:
> > Documentation/devicetree/bindings/input/adi,adp5588.example.dts] Error 1
> > make[2]: *** Waiting for unfinished jobs....
> > make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1432:
> > dt_binding_check] Error 2
> > make: *** [Makefile:224: __sub-make] Error 2
> > 
> 
> Apologies, it seems like I accidently deleted the characters towards the end 
> of the yaml file when making changes...

If you make any changes, particularly to an already reviewed binding,
please be sure to run the tests again before sending.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)