linux-kernel - Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrrWi0HuAIDe7C0x@lizhi-Precision-Tower-5810>
Date: Mon, 12 Aug 2024 23:44:11 -0400
From: Frank Li <Frank.li@....com>
To: Liu Ying <victor.liu@....com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>,
	Jessica Zhang <quic_jesszhan@...cinc.com>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Sam Ravnborg <sam@...nborg.org>,
	"open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports:
 use unevaluatedProperties

On Tue, Aug 13, 2024 at 10:32:04AM +0800, Liu Ying wrote:
> On 08/13/2024, Frank Li wrote:
> > Replace additionalProperties with unevaluatedProperties because it ref to
> > panel-common.yaml.
>
> This would allow all properties in panel-common.yaml, which is not expected.
> Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough?

Strange, you ref to panel-common.yaml, suppose it will use all common
preperties.

Krzysztof Kozlowski:

Can I just add panel-timing:true for this case?

Frank

>
> >
> > Remove properties (backlight, enable-gpios and power-supply), which defined
> > in panel-common.yaml.
> >
> > Fix below warning:
> > arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+'
> >         from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml#
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  .../display/panel/panel-simple-lvds-dual-ports.yaml         | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > index e78160d1aa24c..10ed4b57232b9 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> > @@ -84,11 +84,7 @@ properties:
> >        - port@0
> >        - port@1
> >
> > -  backlight: true
> > -  enable-gpios: true
> > -  power-supply: true
> > -
> > -additionalProperties: false
> > +unevaluatedProperties: false
> >
> >  required:
> >    - compatible
>
> --
> Regards,
> Liu Ying
>