linux-kernel - Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <143d7bcb-c3ee-4f9f-833c-6680a25681b2@nxp.com>
Date: Tue, 13 Aug 2024 10:32:04 +0800
From: Liu Ying <victor.liu@....com>
To: Frank Li <Frank.Li@....com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <quic_jesszhan@...cinc.com>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Thierry Reding
 <thierry.reding@...il.com>, Sam Ravnborg <sam@...nborg.org>,
 "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Cc: imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: display: panel-simple-lvds-dual-ports:
 use unevaluatedProperties

On 08/13/2024, Frank Li wrote:
> Replace additionalProperties with unevaluatedProperties because it ref to
> panel-common.yaml.

This would allow all properties in panel-common.yaml, which is not expected.
Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough?

> 
> Remove properties (backlight, enable-gpios and power-supply), which defined
> in panel-common.yaml.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  .../display/panel/panel-simple-lvds-dual-ports.yaml         | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> index e78160d1aa24c..10ed4b57232b9 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> @@ -84,11 +84,7 @@ properties:
>        - port@0
>        - port@1
>  
> -  backlight: true
> -  enable-gpios: true
> -  power-supply: true
> -
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  required:
>    - compatible

-- 
Regards,
Liu Ying