linux-kernel - Re: [PATCH v2 1/2] userfaultfd: Fix checks for huge PMDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG48ez2P=k6Eezhu+E5OUzPLFpY5C4rCds1y842oyBC1ux3ocw@mail.gmail.com>
Date: Tue, 13 Aug 2024 22:44:10 +0200
From: Jann Horn <jannh@...gle.com>
To: David Hildenbrand <david@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Pavel Emelianov <xemul@...tuozzo.com>, 
	Andrea Arcangeli <aarcange@...hat.com>, Hugh Dickins <hughd@...gle.com>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org, Qi Zheng <zhengqi.arch@...edance.com>, 
	stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] userfaultfd: Fix checks for huge PMDs

On Tue, Aug 13, 2024 at 10:37 PM David Hildenbrand <david@...hat.com> wrote:
> On 13.08.24 22:25, Jann Horn wrote:
> > +             if (unlikely(!pmd_present(dst_pmdval) || pmd_trans_huge(dst_pmdval) ||
> > +                          pmd_devmap(dst_pmdval))) {
>
> Likely in the future we should turn the latter part into a "pmd_leaf()"
> check.

Yeah, it'd be a good idea to refactor that as a followup.