linux-kernel - Re: [PATCH] fuse: fix race conditions on fi->nlookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b7ac9cf-8cac-4066-a334-94a4acb4b678@fastmail.fm>
Date: Tue, 13 Aug 2024 22:47:35 +0200
From: Bernd Schubert <bernd.schubert@...tmail.fm>
To: yangyun <yangyun50@...wei.com>, Miklos Szeredi <miklos@...redi.hu>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
 lixiaokeng@...wei.com
Subject: Re: [PATCH] fuse: fix race conditions on fi->nlookup



On 8/10/24 05:42, yangyun wrote:
> Lock on fi->nlookup is missed in fuse_fill_super_submount(). Add lock
> on it to prevent race conditions.
> 
> Fixes: 1866d779d5d2 ("fuse: Allow fuse_fill_super_common() for submounts")
> Cc: stable@...r.kernel.org
> Signed-off-by: yangyun <yangyun50@...wei.com>
> ---
>  fs/fuse/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
> index 99e44ea7d875..2e220f245ceb 100644
> --- a/fs/fuse/inode.c
> +++ b/fs/fuse/inode.c
> @@ -1593,7 +1593,9 @@ static int fuse_fill_super_submount(struct super_block *sb,
>  	 * that, though, so undo it here.
>  	 */
>  	fi = get_fuse_inode(root);
> +	spin_lock(&fi->lock);
>  	fi->nlookup--;
> +	spin_unlock(&fi->lock);
>  
>  	sb->s_d_op = &fuse_dentry_operations;
>  	sb->s_root = d_make_root(root);

LGTM


Reviewed-by: Bernd Schubert <bschubert@....com>