linux-kernel - Re: [PATCH] fuse: fix race conditions on fi->nlookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJfpegtgp1brE3kY+juseZ+P_hfzbgYwG52eGc1BvR0XsBq2Bw@mail.gmail.com>
Date: Thu, 22 Aug 2024 17:17:49 +0200
From: Miklos Szeredi <miklos@...redi.hu>
To: yangyun <yangyun50@...wei.com>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lixiaokeng@...wei.com
Subject: Re: [PATCH] fuse: fix race conditions on fi->nlookup

On Sat, 10 Aug 2024 at 05:42, yangyun <yangyun50@...wei.com> wrote:
>
> Lock on fi->nlookup is missed in fuse_fill_super_submount(). Add lock
> on it to prevent race conditions.

It's okay to do this without lockinghere, because this is a brand new
superblock and and a brand new root inode for that superblock, so
there's no possible access from outside this function.

So just a comment should suffice.

Thanks,
Miklos