linux-kernel - Re: [PATCH] irqchip/gic-v3: Allow unused SGIs for drivers/modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87le10rewb.ffs@tglx>
Date: Tue, 13 Aug 2024 10:44:04 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Shanker Donthineni <sdonthineni@...dia.com>, Marc Zyngier
 <maz@...nel.org>, Catalin Marinas <catalin.marinas@....com>, Will Deacon
 <will@...nel.org>, Jonathan Corbet <corbet@....net>, Sudeep Holla
 <sudeep.holla@....com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Shanker Donthineni <sdonthineni@...dia.com>
Subject: Re: [PATCH] irqchip/gic-v3: Allow unused SGIs for drivers/modules

On Mon, Aug 12 2024 at 22:39, Shanker Donthineni wrote:
> The commit 897e9e60c016 ("firmware: arm_ffa: Initial support for scheduler
> receiver interrupt") adds support for SGI interrupts in the FFA driver.
> However, the validation for SGIs in the GICv3 is too strict, causing the
> driver probe to fail.
>
> This patch relaxes the SGI validation check, allowing callers to use SGIs

# git grep "This patch" Documentation/process.

> if the requested SGI number is greater than or equal to MAX_IPI, which
> fixes the TFA driver probe failure.
>
> This issue is observed on NVIDIA server platform with FFA-v1.1.
>  [    7.918099] PTP clock support registered
>  [    7.922110] EDAC MC: Ver: 3.0.0
>  [    7.945063] ARM FF-A: Driver version 1.1
>  [    7.949068] ARM FF-A: Firmware version 1.1 found
>  [    7.977832] GICv3: [Firmware Bug]: Illegal GSI8 translation request
>  [    7.984237] ARM FF-A: Failed to create IRQ mapping!
>  [    7.989220] ARM FF-A: Notification setup failed -61, not enabled
>  [    8.000198] ARM FF-A: Failed to register driver sched callback -95
>  [    8.011322] scmi_core: SCMI protocol bus registered

Please get rid of the time stamps and reduce it to the relevant
parts. Neither the time stamps nor PTP/EDAC/SCMI provide any useful
information.

Thanks,

        tglx