linux-kernel - Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a93b8d25-1bec-4a6f-9cb2-e8c59b923180@linaro.org>
Date: Tue, 13 Aug 2024 12:14:39 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: "Potthuri, Sai Krishna" <sai.krishna.potthuri@....com>,
 Linus Walleij <linus.walleij@...aro.org>,
 "Simek, Michal" <michal.simek@....com>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 "Buddhabhatti, Jay" <jay.buddhabhatti@....com>,
 "Kundanala, Praveen Teja" <praveen.teja.kundanala@....com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "saikrishna12468@...il.com" <saikrishna12468@...il.com>,
 "git (AMD-Xilinx)" <git@....com>
Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx
 Versal platform

On 13/08/2024 07:40, Potthuri, Sai Krishna wrote:
>> sd1_wp_0_grp, sd1_wp_1_grp,
>>> +                         ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp,
>> qspi0_fbclk_0_grp, qspi0_ss_0_grp,
>>> +                         test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp]
>>> +            maxItems: 78
>>
>> You miss minItems... I have doubts this was really tested.
> groups/pins are mentioned as required property.
> Do we still need to define minItems?

These are two unrelated concepts. How many items can be listed at once
in each property?

> 
> ....
> 
>>> +
>>> +      drive-strength:
>>
>> drive-strength-microamp
> In this case, values are in mA.

Ah, no, if it is mA, then existing property is correct.

> Do we still need to use drive-strength-microamp?



Best regards,
Krzysztof