linux-kernel - RE: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BY5PR12MB4258AE889108439ECAA4B1C2DB862@BY5PR12MB4258.namprd12.prod.outlook.com>
Date: Tue, 13 Aug 2024 05:40:58 +0000
From: "Potthuri, Sai Krishna" <sai.krishna.potthuri@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Linus Walleij
	<linus.walleij@...aro.org>, "Simek, Michal" <michal.simek@....com>, Rob
 Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>,
	"Buddhabhatti, Jay" <jay.buddhabhatti@....com>, "Kundanala, Praveen Teja"
	<praveen.teja.kundanala@....com>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "saikrishna12468@...il.com"
	<saikrishna12468@...il.com>, "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx
 Versal platform

Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Saturday, August 10, 2024 7:05 PM
> To: Potthuri, Sai Krishna <sai.krishna.potthuri@....com>; Linus Walleij
> <linus.walleij@...aro.org>; Simek, Michal <michal.simek@....com>; Rob
> Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley <conor+dt@...nel.org>;
> Buddhabhatti, Jay <jay.buddhabhatti@....com>; Kundanala, Praveen Teja
> <praveen.teja.kundanala@....com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>
> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> linux-gpio@...r.kernel.org; devicetree@...r.kernel.org;
> saikrishna12468@...il.com; git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH v3 1/3] dt-bindings: pinctrl: Add support for Xilinx Versal
> platform
> 
> On 08/08/2024 07:53, Potthuri, Sai Krishna wrote:
> >>>  1 file changed, 398 insertions(+)
> >
> >>> +      bias-pull-up: true
> >>> +
> >>> +      bias-pull-down: true
> >>> +
> >>> +      bias-disable: true
> >>> +
> >>> +      input-schmitt-enable: true
> >>> +
> >>> +      input-schmitt-disable: true
> >>> +
> >>> +      bias-high-impedance: true
> >>> +
> >>> +      low-power-enable: true
> >>> +
> >>> +      low-power-disable: true
> >>
> >> Why do you need to copy all of these? Just switch to
> unevaluatedProperties.
> > I tried with "unevaluatedProperties: false", it worked but by adding
> > this all the properties in the pincfg-node.yaml become valid for this
> > platform which is not true. Not all the properties in the pincfg-node.yaml
> are supported in this platform.
> > So, is there any other way of representing this?
> 
> If they do not make any sense, then sure, you can keep it like this.
> Drop the blank lines between each of these, so it will be compact.
Ok, will do it.

Also, do you agree with my comments which I replied in other thread?
Pasting those comments below for reference,

> sd1_wp_0_grp, sd1_wp_1_grp,
> > +                         ospi0_0_grp, ospi0_ss_0_grp, qspi0_0_grp,
> qspi0_fbclk_0_grp, qspi0_ss_0_grp,
> > +                         test_clk_0_grp, test_scan_0_grp, tamper_trigger_0_grp]
> > +            maxItems: 78
> 
> You miss minItems... I have doubts this was really tested.
groups/pins are mentioned as required property.
Do we still need to define minItems?

....

> > +
> > +      drive-strength:
> 
> drive-strength-microamp
In this case, values are in mA.
Do we still need to use drive-strength-microamp?

Regards
Sai Krishna