linux-kernel - Re: [PATCH v8 1/4] rpmb: add Replay Protected Memory Block (RPMB) subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024081315-cofounder-stem-8b3d@gregkh>
Date: Tue, 13 Aug 2024 14:41:06 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@...el.com>
Cc: Jens Wiklander <jens.wiklander@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"op-tee@...ts.trustedfirmware.org" <op-tee@...ts.trustedfirmware.org>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Shyam Saini <shyamsaini@...ux.microsoft.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Jerome Forissier <jerome.forissier@...aro.org>,
	Sumit Garg <sumit.garg@...aro.org>,
	Ilias Apalodimas <ilias.apalodimas@...aro.org>,
	Bart Van Assche <bvanassche@....org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Ard Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...db.de>,
	Manuel Traut <manut@...ka.net>,
	Mikko Rapeli <mikko.rapeli@...aro.org>,
	Alex Bennée <alex.bennee@...aro.org>
Subject: Re: [PATCH v8 1/4] rpmb: add Replay Protected Memory Block (RPMB)
 subsystem

On Tue, Aug 13, 2024 at 12:04:03PM +0000, Winkler, Tomas wrote:
> > 
> > On Tue, Aug 13, 2024 at 01:26:18PM +0200, Jens Wiklander wrote:
> > > On Tue, Aug 13, 2024 at 11:29 AM Greg Kroah-Hartman
> > > <gregkh@...uxfoundation.org> wrote:
> > > >
> > > > On Mon, Aug 12, 2024 at 03:31:24PM +0200, Jens Wiklander wrote:
> > > > > --- /dev/null
> > > > > +++ b/drivers/misc/rpmb-core.c
> > > > > @@ -0,0 +1,233 @@
> > > > > +// SPDX-License-Identifier: GPL-2.0
> > > >
> > > > Fine, but:
> > > >
> > > > > --- /dev/null
> > > > > +++ b/include/linux/rpmb.h
> > > > > @@ -0,0 +1,136 @@
> > > > > +/* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0 */
> > > >
> > > > Really?
> > > >
> > > > Why?  I need lots of documentation and a lawyer sign off for why
> > > > this is a dual license for a file that is obviously only for
> > > > internal Linux kernel stuff.
> 
> This was legal approved.

This internal Linux kernel header file for an internal-only Linux kernel
api?  Wonderful, please get the Intel lawyer who agreed with that to
sign off on the commit next time around explaining why it needs to be
this way.

thanks,

greg k-h