linux-kernel - Re: [PATCH v8 3/4] tee: add tee_device_set_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHUa44G6JHLyUCd=ZAaDY=jjsKJWFiQJ=r7u9kEKK4L8crHqrA@mail.gmail.com>
Date: Tue, 13 Aug 2024 14:55:21 +0200
From: Jens Wiklander <jens.wiklander@...aro.org>
To: Sumit Garg <sumit.garg@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, 
	op-tee@...ts.trustedfirmware.org, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Shyam Saini <shyamsaini@...ux.microsoft.com>, Linus Walleij <linus.walleij@...aro.org>, 
	Jerome Forissier <jerome.forissier@...aro.org>, 
	Ilias Apalodimas <ilias.apalodimas@...aro.org>, Bart Van Assche <bvanassche@....org>, 
	Randy Dunlap <rdunlap@...radead.org>, Ard Biesheuvel <ardb@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
	Manuel Traut <manut@...ka.net>, Mikko Rapeli <mikko.rapeli@...aro.org>
Subject: Re: [PATCH v8 3/4] tee: add tee_device_set_dev_groups()

Hi Sumit,

On Tue, Aug 13, 2024 at 1:40 PM Sumit Garg <sumit.garg@...aro.org> wrote:
>
> Hi Jens,
>
> On Mon, 12 Aug 2024 at 19:01, Jens Wiklander <jens.wiklander@...aro.org> wrote:
> >
> > Add tee_device_set_dev_groups() to TEE drivers to supply driver specific
> > attribute groups. The class specific attributes are from now on added
> > via the tee_class, which currently only consist of implementation_id.
> >
> > Signed-off-by: Jens Wiklander <jens.wiklander@...aro.org>
> > ---
> >  drivers/misc/rpmb-core.c | 155 +++++++++++++++++++--------------------
>
> These changes don't seem to belong to this patch but rather patch #1.
>
> >  drivers/tee/tee_core.c   |  19 +++--
>
> >  include/linux/rpmb.h     |  53 +++++--------
>
> Ditto here.

Ouch, thanks for noticing this. I'll fix it in the next version.

Cheers,
Jens