linux-kernel - Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72k-haQ5dnUcNx5h1bE1J6_K=K3X+aqv7qJ2K6nag8izyA@mail.gmail.com>
Date: Wed, 14 Aug 2024 18:16:34 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Alice Ryhl <aliceryhl@...gle.com>, ojeda@...nel.org, alex.gaynor@...il.com, 
	wedsonaf@...il.com, boqun.feng@...il.com, gary@...yguo.net, 
	bjorn3_gh@...tonmail.com, benno.lossin@...ton.me, a.hindborg@...sung.com, 
	akpm@...ux-foundation.org, daniel.almeida@...labora.com, 
	faith.ekstrand@...labora.com, boris.brezillon@...labora.com, 
	lina@...hilina.net, mcanal@...lia.com, zhiw@...dia.com, cjia@...dia.com, 
	jhubbard@...dia.com, airlied@...hat.com, ajanulgu@...hat.com, 
	lyude@...hat.com, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v5 04/26] rust: alloc: implement `Allocator` for `Kmalloc`

On Wed, Aug 14, 2024 at 6:02 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> I checked about `__must_check`, because it would be nice if it is used
> by `bindgen`, and it turns out it already does, but behind
> `--enable-function-attribute-detection` (apparently for performance
> reasons):

I just tried, and the flag seems to work, gives us a bunch of
`#[must_use]`s which are nice, and apparently no other change (in
usual x86_64 config at least).

I don't notice any significant performance difference in our case, so
I will send a quick patch to see if others find an issue with it.

Cheers,
Miguel