linux-kernel - Re: [PATCH 1/5] ARM: dts: microchip: Clean up spacing and indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e37e263-ee00-41bd-a650-1c1374e24d66@microchip.com>
Date: Wed, 14 Aug 2024 13:32:54 +0000
From: <Andrei.Simion@...rochip.com>
To: <krzk@...nel.org>, <claudiu.beznea@...on.dev>,
	<Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
	<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<peda@...ntia.se>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <Cristian.Birsan@...rochip.com>
Subject: Re: [PATCH 1/5] ARM: dts: microchip: Clean up spacing and indentation

On 14.08.2024 16:20, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 14/08/2024 14:26, Andrei Simion wrote:
>> Checkpatch.pl reports some ERRORS related
>> to coding style (spacing and indentation).
>> So clean up : checkpatch.pl --fix-inplace
> 
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
> 

checkpatch.pl has no lower limit for the number of characters.
If you want 75 cols. OK for me.


> Please be specific what are you changing.
> 

It was a bigger/bloated patch and I split it into smaller 
ones based on what ARM/Microchip (AT91) Maintainer said.

> 
>>
>> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>
>> ---
>> Split the bloated patch into small patches on topics
>> based on comments:
>> https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/
>> ---
>>  arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts  | 2 +-
>>  arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts | 8 ++++----
>>  arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts      | 8 ++++----
>>  arch/arm/boot/dts/microchip/at91sam9263ek.dts         | 2 +-
>>  4 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
>> index 04cb7bee937d..1279dfb38300 100644
>> --- a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
>> +++ b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
>> @@ -7,7 +7,7 @@
>>   *                   HCE Engineering
>>   *
>>   * Derived from at91sam9g35ek.dts by:
>> - *   Copyright (C) 2012 Atmel,
>> + *   Copyright (C) 2012 Atmel,
> 
> Not sure what you are fixing here, but unnecessary tab was here before
> and still exists...
> 

WARNING: please, no space before tabs
#10: FILE: arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts:10:
+ * ^ICopyright (C) 2012 Atmel,$

after this patch : this warning disappears.

>>   *      2012 Nicolas Ferre <nicolas.ferre@...el.com>
>>   */
>>
> 
> Best regards,
> Krzysztof
> 

BR,
Andrei Simion