linux-kernel - Re: [PATCH 1/5] ARM: dts: microchip: Clean up spacing and indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a71f5d8e-57bd-4e8e-b0fa-8b9468ec96eb@kernel.org>
Date: Wed, 14 Aug 2024 15:57:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrei.Simion@...rochip.com, claudiu.beznea@...on.dev,
 Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, peda@...ntia.se
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, Cristian.Birsan@...rochip.com
Subject: Re: [PATCH 1/5] ARM: dts: microchip: Clean up spacing and indentation

On 14/08/2024 15:32, Andrei.Simion@...rochip.com wrote:
> On 14.08.2024 16:20, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 14/08/2024 14:26, Andrei Simion wrote:
>>> Checkpatch.pl reports some ERRORS related
>>> to coding style (spacing and indentation).
>>> So clean up : checkpatch.pl --fix-inplace
>>
>> Please wrap commit message according to Linux coding style / submission
>> process (neither too early nor over the limit):
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>>
> 
> checkpatch.pl has no lower limit for the number of characters.
> If you want 75 cols. OK for me.

That
has
nothing
to
do
with
checkpatch
but
with
readability. Please
read
submitting patches document.

> 
> 
>> Please be specific what are you changing.
>>
> 
> It was a bigger/bloated patch and I split it into smaller 
> ones based on what ARM/Microchip (AT91) Maintainer said.

I meant, what the commit is doing.

> 
>>
>>>
>>> Signed-off-by: Andrei Simion <andrei.simion@...rochip.com>
>>> ---
>>> Split the bloated patch into small patches on topics
>>> based on comments:
>>> https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/
>>> ---
>>>  arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts  | 2 +-
>>>  arch/arm/boot/dts/microchip/at91-sama5d27_som1_ek.dts | 8 ++++----
>>>  arch/arm/boot/dts/microchip/at91-sama5d2_icp.dts      | 8 ++++----
>>>  arch/arm/boot/dts/microchip/at91sam9263ek.dts         | 2 +-
>>>  4 files changed, 10 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
>>> index 04cb7bee937d..1279dfb38300 100644
>>> --- a/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
>>> +++ b/arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts
>>> @@ -7,7 +7,7 @@
>>>   *                   HCE Engineering
>>>   *
>>>   * Derived from at91sam9g35ek.dts by:
>>> - *   Copyright (C) 2012 Atmel,
>>> + *   Copyright (C) 2012 Atmel,
>>
>> Not sure what you are fixing here, but unnecessary tab was here before
>> and still exists...
>>
> 
> WARNING: please, no space before tabs
> #10: FILE: arch/arm/boot/dts/microchip/at91-cosino_mega2560.dts:10:
> + * ^ICopyright (C) 2012 Atmel,$
> 
> after this patch : this warning disappears.

Yeah, but code is not correct, is it?

Do not run checkpatch --inplace and commit the changes. Who gave you
such idea?

Instead fix the actual issue in a correct way.



Best regards,
Krzysztof