linux-kernel - Re: [PATCH v3 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240814-passable-phrasing-7e78fce590f5@spud>
Date: Wed, 14 Aug 2024 15:26:45 +0100
From: Conor Dooley <conor@...nel.org>
To: Jan Kiszka <jan.kiszka@...mens.com>
Cc: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
	Tero Kristo <kristo@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, Bao Cheng Su <baocheng.su@...mens.com>,
	Diogo Ivo <diogo.ivo@...mens.com>
Subject: Re: [PATCH v3 2/3] dt-bindings: soc: ti: am645-system-controller:
 add child nodes used by main domain

On Wed, Aug 14, 2024 at 06:49:39AM +0200, Jan Kiszka wrote:
> On 13.08.24 17:40, Conor Dooley wrote:
> > On Tue, Aug 13, 2024 at 08:04:59AM +0200, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@...mens.com>
> >>
> >> Expand bindings to cover both the MCU and the main usage of the AM654
> >> system controller.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> >> ---
> >>  .../soc/ti/ti,am654-system-controller.yaml    | 25 +++++++++++++++++++
> >>  1 file changed, 25 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> index e79803e586ca..5a689ec3c5c9 100644
> >> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> >> @@ -29,11 +29,36 @@ properties:
> >>  
> >>    ranges: true
> >>  
> >> +  mux-controller:
> >> +    type: object
> >> +    ref: /schemas/mux/reg-mux.yaml#
> >> +    description:
> >> +      This is the SERDES lane control mux.
> >> +
> >>  patternProperties:
> >>    "^phy@[0-9a-f]+$":
> >>      type: object
> >>      $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
> >>  
> >> +  "^clock@[0-9a-f]+$":
> > 
> > Could you explain to me why these are all patternProperties? Why are the
> > addresses of these things not fixed for an am654?
> > 
> 
> I could indeed spell out dss-oldi-io-ctrl@...0 and
> clock-controller@...0, and their addresses are likely fixed, indeed. But
> there are also clock@...0 and clock@...0 - should I duplicate their
> object descriptions while moving them to the regular properties?

If you're going to itemise the 3 clocks, I think you should mention
what's different about each of them. Otherwise, if they're all
identical, leave them as a patternProperty.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)