linux-kernel - Re: [PATCH] irqchip/gic-v3: Allow unused SGIs for drivers/modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408151138.JtTxkiQ6-lkp@intel.com>
Date: Thu, 15 Aug 2024 11:37:05 +0800
From: kernel test robot <lkp@...el.com>
To: Shanker Donthineni <sdonthineni@...dia.com>,
	Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Jonathan Corbet <corbet@....net>,
	Sudeep Holla <sudeep.holla@....com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Shanker Donthineni <sdonthineni@...dia.com>
Subject: Re: [PATCH] irqchip/gic-v3: Allow unused SGIs for drivers/modules

Hi Shanker,

kernel test robot noticed the following build errors:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on tip/irq/core soc/for-next linus/master v6.11-rc3 next-20240814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shanker-Donthineni/irqchip-gic-v3-Allow-unused-SGIs-for-drivers-modules/20240814-221122
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
patch link:    https://lore.kernel.org/r/20240813033925.925947-1-sdonthineni%40nvidia.com
patch subject: [PATCH] irqchip/gic-v3: Allow unused SGIs for drivers/modules
config: arm-randconfig-004-20240815 (https://download.01.org/0day-ci/archive/20240815/202408151138.JtTxkiQ6-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240815/202408151138.JtTxkiQ6-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408151138.JtTxkiQ6-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/irqchip/irq-gic-v3.c: In function 'gic_irq_domain_translate':
>> drivers/irqchip/irq-gic-v3.c:1658:40: error: 'MAX_IPI' undeclared (first use in this function); did you mean 'MAX_INPUT'?
    1658 |                 if (fwspec->param[0] < MAX_IPI) {
         |                                        ^~~~~~~
         |                                        MAX_INPUT
   drivers/irqchip/irq-gic-v3.c:1658:40: note: each undeclared identifier is reported only once for each function it appears in


vim +1658 drivers/irqchip/irq-gic-v3.c

  1600	
  1601	static int gic_irq_domain_translate(struct irq_domain *d,
  1602					    struct irq_fwspec *fwspec,
  1603					    unsigned long *hwirq,
  1604					    unsigned int *type)
  1605	{
  1606		if (fwspec->param_count == 1 && fwspec->param[0] < 16) {
  1607			*hwirq = fwspec->param[0];
  1608			*type = IRQ_TYPE_EDGE_RISING;
  1609			return 0;
  1610		}
  1611	
  1612		if (is_of_node(fwspec->fwnode)) {
  1613			if (fwspec->param_count < 3)
  1614				return -EINVAL;
  1615	
  1616			switch (fwspec->param[0]) {
  1617			case 0:			/* SPI */
  1618				*hwirq = fwspec->param[1] + 32;
  1619				break;
  1620			case 1:			/* PPI */
  1621				*hwirq = fwspec->param[1] + 16;
  1622				break;
  1623			case 2:			/* ESPI */
  1624				*hwirq = fwspec->param[1] + ESPI_BASE_INTID;
  1625				break;
  1626			case 3:			/* EPPI */
  1627				*hwirq = fwspec->param[1] + EPPI_BASE_INTID;
  1628				break;
  1629			case GIC_IRQ_TYPE_LPI:	/* LPI */
  1630				*hwirq = fwspec->param[1];
  1631				break;
  1632			case GIC_IRQ_TYPE_PARTITION:
  1633				*hwirq = fwspec->param[1];
  1634				if (fwspec->param[1] >= 16)
  1635					*hwirq += EPPI_BASE_INTID - 16;
  1636				else
  1637					*hwirq += 16;
  1638				break;
  1639			default:
  1640				return -EINVAL;
  1641			}
  1642	
  1643			*type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
  1644	
  1645			/*
  1646			 * Make it clear that broken DTs are... broken.
  1647			 * Partitioned PPIs are an unfortunate exception.
  1648			 */
  1649			WARN_ON(*type == IRQ_TYPE_NONE &&
  1650				fwspec->param[0] != GIC_IRQ_TYPE_PARTITION);
  1651			return 0;
  1652		}
  1653	
  1654		if (is_fwnode_irqchip(fwspec->fwnode)) {
  1655			if(fwspec->param_count != 2)
  1656				return -EINVAL;
  1657	
> 1658			if (fwspec->param[0] < MAX_IPI) {
  1659				pr_err(FW_BUG "Illegal GSI%d translation request\n",
  1660				       fwspec->param[0]);
  1661				return -EINVAL;
  1662			}
  1663	
  1664			*hwirq = fwspec->param[0];
  1665			*type = fwspec->param[1];
  1666	
  1667			WARN_ON(*type == IRQ_TYPE_NONE);
  1668			return 0;
  1669		}
  1670	
  1671		return -EINVAL;
  1672	}
  1673	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki