linux-kernel - Re: [PATCH v5 3/4] scripts: add verifier script for builtin module range data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zr1TvFAu56dd+u8j@oracle.com>
Date: Wed, 14 Aug 2024 21:02:52 -0400
From: Kris Van Hees <kris.van.hees@...cle.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Kris Van Hees <kris.van.hees@...cle.com>, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org, linux-modules@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org,
        Nick Alcock <nick.alcock@...cle.com>,
        Alan Maguire <alan.maguire@...cle.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Jiri Olsa <olsajiri@...il.com>,
        Elena Zannoni <elena.zannoni@...cle.com>
Subject: Re: [PATCH v5 3/4] scripts: add verifier script for builtin module
 range data

On Wed, Aug 14, 2024 at 04:16:06PM -0400, Steven Rostedt wrote:
> On Wed, 14 Aug 2024 15:59:58 -0400
> Kris Van Hees <kris.van.hees@...cle.com> wrote:
> 
> > > What does this mean?  
> > 
> > Hm, this is certainly why the validation script exists.  I am surprised, though
> > not entirely because kernel changes toward the 6.10 branching and such came
> > after I create this version.  Would you be willing to send me a copy of your
> > .config for this kernel build so I can investigate?  This output is typical
> > of a case where the script was not able to determine offse ranges correctly.
> 
> Attached.

So, looking back at your output it seems that the problem is that I did not
make it obvious that the verifier script is written to be executed from the
root of the kernel build tree, i.e. where the objects are stored.  I'll add
support for an optional extra argument to the script so that a path to the
actual object tree can be provided.  That was an important oversight on my
part - sorry about that.

So, if your kernel is built into an object directory, the script in its
current state would need to be executed with that object directory as current
working directory.

I.e. if the build directory is /work/build/nobackup/debiantesting-x86-64/ and
the kernel source tree is in /work/source/linux, change CWD to that build
directory and invoke the verifier as:

/work/source/linux/scripts/verify_builtin_ranges.awk modules.builtin.ranges System.map modules.builtin vmlinux.map vmlinux.o.map

Can you try that and verify that the output is correct in that case?  I expect
it will be.

v6 of the series (which I hope to post tomorrow) will allow you to specify
the path to the object tree so that this will be more user friendly.

	Kris