[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20240815010337.2334245-1-philipchen@chromium.org>
Date: Thu, 15 Aug 2024 01:03:37 +0000
From: Philip Chen <philipchen@...omium.org>
To: Pankaj Gupta <pankaj.gupta.linux@...il.com>,
Dan Williams <dan.j.williams@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>,
Ira Weiny <ira.weiny@...el.com>
Cc: virtualization@...ts.linux.dev,
nvdimm@...ts.linux.dev,
linux-kernel@...r.kernel.org,
Philip Chen <philipchen@...omium.org>
Subject: [PATCH v2] virtio_pmem: Check device status before requesting flush
If a pmem device is in a bad status, the driver side could wait for
host ack forever in virtio_pmem_flush(), causing the system to hang.
Signed-off-by: Philip Chen <philipchen@...omium.org>
---
Change since v1:
- Remove change id from the patch description
drivers/nvdimm/nd_virtio.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/nvdimm/nd_virtio.c b/drivers/nvdimm/nd_virtio.c
index 35c8fbbba10e..3b4d07aa8447 100644
--- a/drivers/nvdimm/nd_virtio.c
+++ b/drivers/nvdimm/nd_virtio.c
@@ -44,6 +44,15 @@ static int virtio_pmem_flush(struct nd_region *nd_region)
unsigned long flags;
int err, err1;
+ /*
+ * Don't bother to send the request to the device if the device is not
+ * acticated.
+ */
+ if (vdev->config->get_status(vdev) & VIRTIO_CONFIG_S_NEEDS_RESET) {
+ dev_info(&vdev->dev, "virtio pmem device needs a reset\n");
+ return -EIO;
+ }
+
might_sleep();
req_data = kmalloc(sizeof(*req_data), GFP_KERNEL);
if (!req_data)
--
2.46.0.76.ge559c4bf1a-goog
Powered by blists - more mailing lists